]> dgit.raspbian.org Git - gnome-shell.git/commit
shell: Use swapped signal connection for MetaWindowActor::destroy
authorCarlos Garnacho <carlosg@gnome.org>
Mon, 1 May 2023 15:04:46 +0000 (17:04 +0200)
committerMarge Bot <marge-bot@gnome.org>
Wed, 3 May 2023 14:00:33 +0000 (14:00 +0000)
commit356bab112154743e69ad3fcbcd9029dc532b262e
treeffe071bd09c16bbf05045d9a50685a2d35d01292
parentb6ab9091805e87c26178f5d09dadf6ee83be0f0d
shell: Use swapped signal connection for MetaWindowActor::destroy

The callback would schedule a clutter_actor_destroy() on the first
argument. Unless told otherwise, this is the same actor that is
already being destroyed, so this is a no-op.

Instead, the intent is to make the clone follow up destruction of
the window actor so that it results in correct removal of this
window from the ShellWindowPreviewLayout. Use a swapped connection
to pass the clone actor as the first argument of the signal callback.

Fixes: 04c781674c ("Move WindowPreviewLayout from JS to C")
Closes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/6570
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2756>
src/shell-window-preview-layout.c